use SERVER_NAME instead of HTTP_HOST as domain for the cookie.#3
Open
rodikal wants to merge 1 commit intosipa:masterfrom
Open
use SERVER_NAME instead of HTTP_HOST as domain for the cookie.#3rodikal wants to merge 1 commit intosipa:masterfrom
rodikal wants to merge 1 commit intosipa:masterfrom
Conversation
use SERVER_NAME instead of HTTP_HOST as domain for the cookie. HTTP_HOST also contains the port (when not running on port 80) , resulting in lost sessions (and an unusable website)
Owner
|
Dat is wel de meest oninformatieve commit title mogelijk denk ik :) |
Contributor
Author
|
Das de default title, ik had er niet aan gedacht om die nog te wijzigen |
Contributor
Author
|
geen zin om deze te mergen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason:
HTTP_HOST also contains the port (when not running on port 80) , resulting in lost sessions (and an unusable website)